Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Typo in Poly3DCollection constructor #26420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rschwa6308 opened this issue Jul 31, 2023 · 2 comments · Fixed by #26532
Closed

Typo in Poly3DCollection constructor #26420

rschwa6308 opened this issue Jul 31, 2023 · 2 comments · Fixed by #26532
Labels
topic: mplot3d
Milestone
v3.7.3

Comments

@rschwa6308
Copy link

There is a typo in Poly3DCollection.__init__() that causes a TypeError exception whenever the function is called with shade=True.

matplotlib/lib/mpl_toolkits/mplot3d/art3d.py

Line 908 in f7a8cab

if facecolors is None and edgecolors in None:

edgecolors in None should be edgecolors is None
@story645
Copy link
Member

story645 commented Jul 31, 2023 •
edited
Loading

want to open a PR to fix that? Also good catch!

@stevezhang1999
Copy link
Contributor

It looks like we rarely enter this branch - I'm investigating how to trigger the bug.

@stevezhang1999 stevezhang1999 mentioned this issue Aug 15, 2023
Merged
2 tasks
@QuLogic QuLogic added this to the v3.7.3 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.7.3
Development

Successfully merging a pull request may close this issue.

Fix input check in Poly3DCollection.__init__ stevezhang1999/matplotlib
5 participants
@QuLogic @story645 @scottshambaugh @rschwa6308 @stevezhang1999