-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Should default hist() bins be changed in 2.0? #4487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Probably not for 2.0, I am pretty adamant about keeping it color/style changes only. This come up recently (#4316) and it got pushed to the numpy mailing list (but I don't know what happened to it there).
If we really want to maintain the adaptive binning code in mpl we should add a #4433 makes one common use case (filled steps) a lot easier to do with pre-binned data. I also have some thoughts that I need to turn into a PR about providing a decorator in |
Fair enough – thanks! |
@tacaswell did you change your opinion, because i would love to see that go into 2.0. Pushing |
Support for automatic bin width selection is on numpy master and will be in numpy 1.11. If the user has a new enough version of numpy installed I am still skeptical of any 'automatic' data analysis (but if @jakevdp trusts it I should probably stop worrying), however I would not want to bump the mpl default until our min numpy version is > 1.11. I think adding an rcparam which sets the default values of |
@jakevdp I'm trying to add support for weighted data for the binwidth selection procedures in numpy (which was overlooked in numpy/numpy#6029). See numpy/numpy#6288 for details. We're currently unsure about how to deal with the various possibilities of the weights, i.e. count-like ( |
Fix #4487: Take hist bins from rcParam
Fix #4487: Take hist bins from rcParam
This was addressed by adding an rcparam. |
Is the numpy dependency high enough to change the default yet? I don't think an In other words: pretty please change the default for the next major version if possible. |
@amueller can you open a new issue with more details of what you are proposing? As much as possible, I think we should just pass arguments through to |
Yes, we are are np.1.15 on master so yes. 👍 on a new issue for this. We currently don't have a target date for 4.0 (which is what we are roughly calling the major re-think), but it may be the case that there are enough breaking, but incremental changes, that people have asked for to be worth doing a "small" major release. [edit to make run on sentence a bit less run-on] |
I would advocate changing the default histogram bins to a data-adaptive choice in 2.0. For an example of how this might look, see info on the recently-merged astropy
hist()
function: http://astropy.readthedocs.org/en/latest/visualization/histogram.html#normal-reference-rulesUsing the freedman-diaconis rule as the default would be a useful change, IMO (though it would require some modification in the case of weighted samples)
The text was updated successfully, but these errors were encountered: