Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Points annotation coords not working in 2.x #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
QuLogic opened this issue Feb 13, 2016 · 6 comments
Closed

Points annotation coords not working in 2.x #5994

QuLogic opened this issue Feb 13, 2016 · 6 comments
Assignees
Milestone

Comments

@QuLogic
Copy link
Member

QuLogic commented Feb 13, 2016

See the annotation demo:
annotation_demo

Both "points" and "bottom right (points)" are in the wrong location.

@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 1.5.2 (Critical bug fix release) Feb 13, 2016
@QuLogic
Copy link
Member Author

QuLogic commented Feb 14, 2016

Oh, I knew I recognized this one from somewhere; it's caused by 7b71257 in 1.5.0. IIRC, this change is in fact desired, so probably the demo needs updating?

@tacaswell
Copy link
Member

Yeah, I we should update the example

@dopplershift
Copy link
Contributor

figure_1
So points is fixed, but for me the color is different and local max is directly vertical above the point (though if I try to move it further, that works). Not sure what to do about the "bottom right (points)" case.

@dopplershift
Copy link
Contributor

Oh, maybe blue color is only with new style?

@tacaswell
Copy link
Member

For reference, this is what it looks like:


1.3.1

image


1.5.1

image


1.5.x

as built in docs

image

as run in a terminal

so

What corner of the 'local max' string the arrow hits is dpi/figure size dependent (it seems to be trying to do something smart and snaps to the closest corner.


master

image


I am in the process of cleaning up this example (with slightly better text as well).

tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 21, 2016
@tacaswell tacaswell self-assigned this May 21, 2016
@tacaswell
Copy link
Member

image

in PR #6455

tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants