re-enable building conda package artifacts on appveyor / fix conda recipe #6460
Comments
|
It seems that due to the way that conda-forge now has a libpng and this lib is differently named, we need a patch: conda-forge/matplotlib-feedstock@410106a#diff-ead893c9f392df956860bfe6a5dae3a8R6 The test run probably work because of https://github.com/matplotlib/matplotlib/blob/master/appveyor.yml#L80 which put the static version into a special dir and renames it. I'm not sure how to proceed: I find it very unfortunate that the conda-forge and default libpng seem to differ. @ocefpaf do you have any idea why that is so? |
The only difference is that we updated Pinging @gillins who might help shed some light in the issue. |
|
I can't even install that lib? c:\data\external\jupyter\jupyter_environment_kernels (conda_windows)
[cf_png] λ conda create -n cf_png2 libpng=1.6.21 -c conda-forge
Using Anaconda Cloud api site https://api.anaconda.org
Fetching package metadata: ..................
Solving package specifications: ....
The following specifications were found to be in conflict:
- libpng 1.6.21*
Use "conda info <package>" to see the dependencies for each package.I compare the vc14 versions of the default channel (.17) and the conda-forge channel (.21): https://anaconda.org/anaconda/libpng/1.6.17/download/win-64/libpng-1.6.17-vc14_1.tar.bz2 The most interesting thing seems to be that the defaults versions contains an extra file called It seems that the original recipe simply copies the file: C:\data\downloads\libpng\win-64-libpng-1.6.17-vc14_1\Library\lib
λ diff libpng.lib png.lib
C:\data\downloads\libpng\win-64-libpng-1.6.17-vc14_1\Library\lib
λ diff libpng16.lib png.lib
C:\data\downloads\libpng\win-64-libpng-1.6.17-vc14_1\Library\lib
λ diff libpng16_static.lib png.lib
Binary files libpng16_static.lib and png.lib differ@ocefpaf: do you think it would be possible to simply do the same? |
|
zlib seems to already do the same: https://github.com/conda-forge/zlib-feedstock/blob/master/recipe/bld.bat#L22 |
|
@ocefpaf:will send a PR against libpng-feedstock... |
matplotlib expects the lib under that name, so add it as well. The file is also in the package from the defaults channel, so this could also be considered a regression against that version. See matplotlib/matplotlib#6460 for the discussion on that topic.
|
PR is in conda-forge/libpng-feedstock#4 |
|
This has been fully superseded by conda-forge, closing. |
In #6423 the conda package building was disabled due to libpng related build failures.
The failures are odd given that the build works the
python setup.py developused for running the tests.See for details #6423 (comment)
The text was updated successfully, but these errors were encountered: