Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Problems with anatomy figure on v2.x #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
QuLogic opened this issue Sep 14, 2016 · 2 comments
Closed

Problems with anatomy figure on v2.x #7113

QuLogic opened this issue Sep 14, 2016 · 2 comments
Assignees
@QuLogic
Labels
API: default changes Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Documentation
Milestone
v2.0.0

Comments

@QuLogic
Copy link
Member

QuLogic commented Sep 14, 2016

Due to several default style changes, there are a few issues with the "anatomy of a figure" example from #7072 when run on v2.x.

  • Ticks are not shown on the top and right spines, so one of the annotations is now on top of nothing.
  • Ticks are outward and overlapping the labels. I'm not totally sure why that's the case. They shouldn't do that by default.
  • Markers have no edge. Combined with the white face, they seem to be invisible.

Most of these should be straightforward to fix when I get a chance if no-one beats me to it.
@QuLogic QuLogic added Documentation API: default changes Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues labels Sep 14, 2016
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Sep 14, 2016
@efiring
Copy link
Member

efiring commented Sep 14, 2016

While you are at it, you could change the call to scatter to a call to plot.

@efiring
Copy link
Member

efiring commented Sep 14, 2016

You have found a major bug: changing the tick length with ax.tick_params does not adjust the tick label locations.

@efiring efiring mentioned this issue Sep 14, 2016
Closed
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 18, 2016
@QuLogic
Update anatomy figure for 2.x style changes.
c3afb33 
* Enable black edges on scatter markers. Also, use `plot` instead of
  `scatter` for @efiring.
* Move major and minor tick annotation to left side, where they're
  visible.
* Shift tick label and axis label annotations outward to match corrected
  handling of tick length.
* Don't disable legend frame, which is not very distracting any more.

Fixes matplotlib#7113.
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Sep 18, 2016
@QuLogic
Update anatomy figure for 2.x style changes.
d26e01f 
* Enable black edges on scatter markers. Also, use `plot` instead of
  `scatter` for @efiring.
* Move major and minor tick annotation to left side, where they're
  visible.
* Shift tick label and axis label annotations outward to match corrected
  handling of tick length.
* Don't disable legend frame, which is not very distracting any more.
* Don't set figure facecolor, which is already white by default now.

Fixes matplotlib#7113.
@QuLogic QuLogic mentioned this issue Sep 18, 2016
Merged
@QuLogic QuLogic self-assigned this Sep 18, 2016
@NelleV NelleV modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Nov 10, 2016
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Nov 15, 2016
@QuLogic
Update anatomy figure for 2.x style changes.
d467e7a 
* Enable black edges on scatter markers. Also, use `plot` instead of
  `scatter` for @efiring.
* Move major and minor tick annotation to left side, where they're
  visible.
* Shift tick label and axis label annotations outward to match corrected
  handling of tick length.
* Don't disable legend frame, which is not very distracting any more.
* Don't set figure facecolor, which is already white by default now.

Fixes matplotlib#7113.
@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuLogic QuLogic

Labels
API: default changes Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Documentation
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@efiring @NelleV @QuLogic