Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Moving get_ax and do_event to testing #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakirkham opened this issue Nov 1, 2016 · 7 comments · Fixed by #17030
Closed

Moving get_ax and do_event to testing #7372

jakirkham opened this issue Nov 1, 2016 · 7 comments · Fixed by #17030
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones!
Milestone
v3.3.0

Comments

@jakirkham
Copy link

I'm wanting to do some testing in a library that uses matplotlib. In particular, this library is using matplotlib native widgets.

There appear to be some utility functions used for testing called get_ax and do_event. These seem like they would be very handy for widget tests like the ones proposed above.

However, I'm not entirely clear on how they can access them ATM as they don't seem to be importable and they are not in testing currently. Would it be possible to move them to testing so they could be used externally? Related would that actually make sense/be usable for my use case?
@jakirkham jakirkham mentioned this issue Nov 1, 2016
Closed
@tacaswell
Copy link
Member

👍

They are not importable because some packings of mpl strip off the the tests module (there is a lot of binary image data in there).

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Nov 1, 2016
@tacaswell tacaswell added Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues new-contributor-friendly labels Nov 1, 2016
@jakirkham
Copy link
Author

They are not importable because some packings of mpl strip off the the tests module (there is a lot of binary image data in there).

That's totally reasonable.

Just wanted to make sure I wasn't missing something big w.r.t. using these functions externally. For instance, will I need to have configured an interactive backend to get them to work?

@tacaswell
Copy link
Member

Doesn't look like it.

That docstring is also very wrong...

@jakirkham
Copy link
Author

Yep, it could use some help. 😄

Alright, I've put this on my ToDos. Can't promise I'll get to it soon, but I do plan to come back to it.

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Oct 3, 2017
@tacaswell tacaswell added the Good first issue Open a pull request against these issues if there are no active ones! label Oct 16, 2017
dakotablair added a commit to dakotablair/matplotlib that referenced this issue Dec 1, 2017
@dakotablair
Fix issue matplotlib#7372, move widget functions into matplotlib.test…
5327660 
…ing.widgets.
@dakotablair dakotablair mentioned this issue Dec 1, 2017
Closed
6 tasks
@SidharthBansal
Copy link
Contributor

lib/matplotlib/testing/widgets.py doesn't exist, so to which file should i move these methods?

@tacaswell
Copy link
Member

@SidharthBansal Please make that file.

@tacaswell
Copy link
Member

I suggest taking the commits in #9905, rebasing them on master, pushing to a branch on your fork and then leaving a note on that 9905 that you have taken over the work.

SidharthBansal added a commit to SidharthBansal/matplotlib that referenced this issue Apr 4, 2020
@SidharthBansal
Fixes matplotlib#7372, move widget functions into matplotlib.testing.…
07e33f5 
…widgets.

Thanks @dakotablair for their work in matplotlib#9905
Closes matplotlib#9905

Co-authored-by: @dakotablair
@SidharthBansal SidharthBansal mentioned this issue Apr 4, 2020
Merged
6 tasks
@QuLogic QuLogic modified the milestones: needs sorting, v3.3.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones!
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Move widget functions into matplotlib.testing.widgets. SidharthBansal/matplotlib
5 participants
@tacaswell @QuLogic @jakirkham @dstansby @SidharthBansal