FIX: Check for fontsize smaller than 1 pt and round up #10010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Jan 9, 2018
QuLogic
reviewed
Jan 9, 2018
lib/matplotlib/font_manager.py
Outdated
| @@ -878,6 +878,10 @@ def set_size(self, size): | |||
| + ", ".join(map(str, font_scalings))) | |||
| else: | |||
| size = scale * FontManager.get_default_size() | |||
| if size < 1.0: | |||
| _log.info('Fontsize %1.2f < 1.0 pt not allowed by FreeType. ' | |||
| 'Setting fontsize = 1 pt' % size) | |||
There was a problem hiding this comment.
You should not be doing the formatting, but passing a separate arg to _log.info, no?
8a6e4f8 to
6c6ef7e
Compare
6c6ef7e to
8d1f597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
FreeType doesn't allow fonts to get smaller than 1 pt, so all Agg backends were silently rounding up to 1 pt. PDF (other vector backends?) were letting us write fonts that were less than 1 pt, but they could not be placed properly because position information comes from FreeType. This change makes it so no backends can use fonts smaller than 1 pt, consistent with FreeType and ensuring more consistent results across backends.
A message is logged at the
logger.INFOlevel. Could be convinced this should be higher level or awarning.warnThe argument against this is that small fonts can currently be written in PDF, but given that their positioning is all borked, this doesn't seem like a good thing to offer.
Its not clear why FreeType doesn't allow smaller fonts.
This addresses, if it doesn't solve #9963
PR Checklist