Thanks to visit codestin.com
Credit goes to github.com

Skip to content

What's new entry for color comparision method #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

What's new entry for color comparision method #10071

wants to merge 5 commits into from

Conversation

surana-mudit
Copy link
Contributor

@surana-mudit surana-mudit commented Dec 21, 2017

Issue #10069

PR Summary

I have added a new file to 'doc/users/next_whats_new' folder for the color comparision method.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@surana-mudit
Copy link
Contributor Author

@dstansby I have added a summary according to my understanding , please tell me if you want me to add something more.

@surana-mudit
Copy link
Contributor Author

@dstansby could you please review it

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, you would reference the new method. In this case its matplotlib.colors.same_color

Wide variety of colors is vague: "colors in Matplotlib can be specified with a wide variety of ways..."

Comparision of 2 colors in Matplotlib
-------------------------------------

As Matplotlib comes with a wide variety of colors, therefore this new version allows 2 legend colors to be compared.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The sentence doesn't quite sound right - I would just remove 'therefore'
  • As @jklymak , could you reference the actual method by adding
`~matplotlib.colors.same_color`

This will show up as a link that says "same_color"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style thing, but I somewhat favour the full names so that users can see what modules routines come from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good point, if you could use this instead:

`matplotlib.colors.same_color`

@dstansby dstansby added this to the v2.2 milestone Dec 26, 2017
@dstansby dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Dec 26, 2017
@jklymak
Copy link
Member

jklymak commented Dec 31, 2017

ping @surana-mudit

@tacaswell
Copy link
Member

Please squash-merge this when it is merged.

@jklymak
Copy link
Member

jklymak commented Jan 2, 2018

@surana-mudit This seems to have been messed up somehow. Can you check that it now does what you want (for instance, the Requested Changes are not showing up).

@surana-mudit
Copy link
Contributor Author

I am extremely sorry for the late response.
I have updated the what's new entry and created a new pull request as referenced above.
I hope we can close this one.

@jklymak jklymak closed this Jan 3, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants