-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
What's new entry for color comparision method #10071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dstansby I have added a summary according to my understanding , please tell me if you want me to add something more. |
@dstansby could you please review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, you would reference the new method. In this case its matplotlib.colors.same_color
Wide variety of colors is vague: "colors in Matplotlib can be specified with a wide variety of ways..."
Comparision of 2 colors in Matplotlib | ||
------------------------------------- | ||
|
||
As Matplotlib comes with a wide variety of colors, therefore this new version allows 2 legend colors to be compared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The sentence doesn't quite sound right - I would just remove 'therefore'
- As @jklymak , could you reference the actual method by adding
`~matplotlib.colors.same_color`
This will show up as a link that says "same_color"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A style thing, but I somewhat favour the full names so that users can see what modules routines come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a good point, if you could use this instead:
`matplotlib.colors.same_color`
ping @surana-mudit |
Please squash-merge this when it is merged. |
@surana-mudit This seems to have been messed up somehow. Can you check that it now does what you want (for instance, the Requested Changes are not showing up). |
I am extremely sorry for the late response. |
Issue #10069
PR Summary
I have added a new file to 'doc/users/next_whats_new' folder for the color comparision method.
PR Checklist