Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prefer vendored qhull if sys-wide version can't be determined. #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 22, 2017

  1. When qhull is available system-wide but its version cannot be
    determined, ignore it (there is no guarantee that it will, in fact,
    work) and fallback to the vendored version.
  2. When adding header paths to vendored libraries, prepend the paths to
    give them higher priority than /usr/{,local/}include. (In reality we
    should just not add the system /usr/{,local/}include paths to the
    compiler invocations at all, but that's a more complicated patch.

Closes #8390, closes #8872; partial fix for #9737 (though not actually sufficient for the issue described in #9737).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

1. When qhull is available system-wide but its version cannot be
determined, ignore it (there is no guarantee that it will, in fact,
work) and fallback to the vendored version.
2. When adding header paths to vendored libraries, prepend the paths to
give them higher priority than /usr/{,local/}include.  (In reality we
should just not add the system /usr/{,local/}include paths to the
compiler invocations at all, but that's a more complicated patch.
@anntzer anntzer added the Build label Dec 22, 2017
@tacaswell tacaswell added this to the v2.2 milestone Dec 22, 2017
@QuLogic QuLogic merged commit a456bd1 into matplotlib:master Dec 22, 2017
@anntzer anntzer deleted the prefer-internal-qhull branch December 22, 2017 19:56
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants