Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate passing strings instead of booleans to control tick state (and other states). #10089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2017
Merged

Deprecate passing strings instead of booleans to control tick state (and other states). #10089

merged 1 commit into from
Dec 28, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 26, 2017

Passing "off" or "false" to mean False is so MATLAB like...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecate passing strings instead of booleans to control tick state.
c9c9b7a 
Passing "off" or "false" to mean False is so MATLAB like...
efiring
efiring approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@dopplershift dopplershift merged commit a919d79 into matplotlib:master Dec 28, 2017
@anntzer anntzer deleted the tick-booleans branch December 28, 2017 21:58
@QuLogic QuLogic added this to the v2.2 milestone Dec 28, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @efiring @dopplershift @jklymak @QuLogic