Minor simplification to _pylab_helpers. #10090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module is private so it's fair game to directly get rid of error_msg.
efiring
approved these changes
Dec 27, 2017
| print(msg, file=sys.stderr) | ||
| import atexit | ||
| import gc | ||
| import sys |
There was a problem hiding this comment.
I'm curious: why did you bother re-ordering these imports? The original order looks fine to me.
There was a problem hiding this comment.
Keeping things in alphabetical order. A bit anal, I admit.
| if f != manager: | ||
| cls._activeQue.append(f) | ||
|
|
||
| cls._activeQue.remove(manager) |
There was a problem hiding this comment.
The functional difference here is that the old code replaces the class attribute _activeQue, while the new code modifies the original. The only way I can see this would make a difference would be if there were other references to _activeQue. It doesn't look like that should occur; and if it did, I don't see how the replacement would be helpful. Therefore, I think this is OK.
dopplershift
approved these changes
Dec 28, 2017
| if manager.canvas.figure == fig: | ||
| num = manager.num | ||
| break | ||
| num = next((manager.num for manager in six.itervalues(cls.figs) |
There was a problem hiding this comment.
That's an interesting pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is private so it's fair game to directly get rid of
error_msg.
PR Summary
PR Checklist