Make errobars work with astropy units #10118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code to test: from astropy.visualization import quantity_support
import astropy.units as u
import matplotlib.pyplot as plt
import numpy as np
quantity_support()
x = np.linspace(0, 10, 10)
y = np.sin(x * np.pi)
yerr = np.random.rand(10)
x_sec = x * u.second
y_meter = y * u.meter
yerr_meter = yerr * u.meter
fig = plt.figure()
ax = fig.add_subplot(111)
ax.errorbar(x_sec, y_meter, yerr_meter)
plt.show() |
|
This might actually be an upstream change needed, so hold off on merging before astropy/astropy#7037 which might be a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8871. The problem was some code was doing list comprehensions, that was returning a list of
Quantity, which is not an instance ofQuantity, so the conversions weren't happening properly further down the line.