Remove most instances of pep8 E502 (redundant backslashes). #10196
Conversation
|
Seems you missed one, though. |
|
Intentionally left: most surrounding lines in that specific context also have backslashes, so I felt breaking the style was not worth it (unless using parentheses for wrapping throughout). |
|
But it's not passing now ;) |
3767e68 to
d5fdebb
Compare
|
Oh, missed that, fixed. I meant that I left a "redundant" backslash (and the exclusion) in geo.py for the reasons stated above. |
| proj = proj3d.proj_trans_points([self._position3d, \ | ||
| self._position3d + self._dir_vec], renderer.M) | ||
| proj = proj3d.proj_trans_points( | ||
| [self._position3d, self._position3d + self._dir_vec], renderer.M) |
There was a problem hiding this comment.
Probably should break before the second arg though.
There was a problem hiding this comment.
the bracketed parts doesn't fit on the same line as "proj_trans_points(" and I think we have plenty of cases where the function is on one line and all the arguments on the next line.
There was a problem hiding this comment.
I mostly say to break here because the first arg is a list using commas for "other" things than separating function arguments.
There was a problem hiding this comment.
I'll follow the vote of the next reviewer.
PR Summary
PR Checklist