improve docstring of Axes.plot_date #10246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jan 14, 2018
lib/matplotlib/dates.py
Outdated
| @@ -20,24 +41,22 @@ | |||
| 732403, whereas using the Gregorian calendar via the datetime | |||
| module we find:: | |||
|
|
|||
| In [31]:date(2006,4,1).toordinal() - date(1,1,1).toordinal() | |||
| Out[31]:732401 | |||
| In [1]: date(2006,4,1).toordinal() - date(1,1,1).toordinal() | |||
There was a problem hiding this comment.
may as well make this pep8-compliant (with spaces after commas)?
1bfc672 to
1b7bc13
Compare
dstansby
approved these changes
Jan 14, 2018
lib/matplotlib/axes/_axes.py
Outdated
| :class:`matplotlib.dates.AutoDateFormatter` (if the tick | ||
| formatter is not already set to a | ||
| :class:`matplotlib.dates.DateFormatter` instance). | ||
| Note: If you are using custom date tickers and formatters, it may be |
There was a problem hiding this comment.
Can this go in the notes section below?
1b7bc13 to
ca5bb47
Compare
|
Push committed the minor change, though @timhoffm let me know if that ruins your workflow, and I won't do again. Sorry for not asking first - I saw "dstansby" and my mind got confused. |
|
There seem to be a conflict, please backport manually |
tacaswell
pushed a commit
that referenced
this pull request
Jan 17, 2018
improve docstring of Axes.plot_date
Conflicts:
lib/matplotlib/dates.py
- both branches changed docstring, kept master version
tacaswell
added a commit
that referenced
this pull request
Jan 18, 2018
Backport of PR #10246: Improve docstring of Axes.plot_date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As part of #10148: Docstring update for
Axes.plot_dateand part ofmatplotlib.dates.