Minor cleanups. #10248
Minor cleanups. #10248
Conversation
| outfile.write(fh.read()) | ||
| with (io.open(tmpfile, 'r', encoding='latin-1') | ||
| if file_requires_unicode(outfile) | ||
| else io.open(tmpfile, 'rb')) as fh: |
There was a problem hiding this comment.
At the risk of bikeshedding... I find this 3-line construct a bit of a trip hazard when reading. How about this:
if file_requires_unicode(outfile):
kwd = dict(mode='r', encoding='latin-1')
else:
kwd = dict(mode='rb')
with io.open(tmpfile, **kwd) as fh:Or if you want to reduce the line count:
kwd = (dict(mode='r', encoding='latin-1') if file_requires_unicode(outfile)
else dict(mode='rb'))
with io.open(tmpfile, **kwd) as fh:The latter option is no longer than your original, and to me, much more readable. I haven't checked, but I hope it doesn't fall afoul of the line length limit.
There was a problem hiding this comment.
Yeah, I totally agree w/ this but thought maybe I was being an anti-fancy-python-tricks stick-in-the-mud
There was a problem hiding this comment.
new version seems a reasonable compromise?
There was a problem hiding this comment.
Was this actually changed? It's not marked outdated.
There was a problem hiding this comment.
Ah, sorry. There were two instances of it, only changed one of them. Will make a separate PR.
PR Summary
PR Checklist