Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Quick and dirty revert of busy cursor for 2.1.2. #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2018
Merged

Quick and dirty revert of busy cursor for 2.1.2. #10254

merged 1 commit into from
Jan 16, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 15, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 15, 2018
@anntzer anntzer added this to the v2.1.2 milestone Jan 15, 2018
tacaswell
tacaswell approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets the job done.

jklymak
jklymak approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get any bad sideeffects from this change, but I didn't test a GUI that does a bunch of redraws...

@jklymak
Copy link
Member

jklymak commented Jan 15, 2018

Do we actually have a test for this problem?

@anntzer
Copy link
Contributor Author

anntzer commented Jan 15, 2018

The problem is not really "testable", just the fact tha continuously switching the cursor was annoying when doing e.g. animations...

@jklymak
Copy link
Member

jklymak commented Jan 15, 2018

Yeah, sorry, I meant an off-line test, not part of the test suite...

@jklymak jklymak merged commit 937889f into matplotlib:master Jan 16, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 16, 2018

There seem to be a conflict, please backport manually

@anntzer anntzer deleted the revert-cursor branch January 16, 2018 17:26
tacaswell pushed a commit that referenced this pull request Jan 17, 2018
@jklymak @tacaswell
Merge pull request #10254 from anntzer/revert-cursor
9ca66ae 
Quick and dirty revert of busy cursor for 2.1.2.

Conflicts:
	lib/matplotlib/backends/backend_gtk3cairo.py
          - other changes to adjacent code, backported minimal change
@tacaswell
Copy link
Member

backported to v2.1.x as 9ca66ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @tacaswell