Thanks to visit codestin.com
Credit goes to github.com

Skip to content

More misc. typos #10266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2018
Merged

More misc. typos #10266

merged 3 commits into from
Jan 23, 2018

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jan 18, 2018

Follow-up to #10261

@tacaswell
Copy link
Member

Thanks!

Do you think it would be possible to run codespell on travis to make sure we do not put spelling errors in to begin with?

@tacaswell tacaswell added this to the v2.2 milestone Jan 18, 2018
tacaswell
tacaswell approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contingent on tests passing

QuLogic
QuLogic reviewed Jan 18, 2018
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few corrections.

lib/matplotlib/backend_tools.py Outdated
@@ -228,7 +228,7 @@ def set_figure(self, figure):
if figure:
self.trigger(self, None)
else:
# if there is no figure, triggen wont change the internal state
# if there is no figure, trigger wont change the internal state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be won't as well.

lib/matplotlib/dates.py Outdated
@@ -1422,15 +1422,15 @@ def autoscale(self):

class MonthLocator(RRuleLocator):
"""
Make ticks on occurances of each month month, e.g., 1, 3, 12.
Make ticks on occurrences of each month month, e.g., 1, 3, 12.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double 'month', I think.

lib/matplotlib/patches.py Outdated
@@ -2831,7 +2831,7 @@ def __reduce__(self):
class Arc3(_Base):
"""
Creates a simple quadratic bezier curve between two
points. The curve is created so that the middle contol points
points. The curve is created so that the middle control points
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

middle control point (not plural)

lib/matplotlib/offsetbox.py Outdated
@@ -626,7 +626,7 @@ def set_offset(self, xy):
"""
set offset of the container.

Accept : tuple of x,y cooridnate in disokay units.
Accept : tuple of x,y coordinate in disokay units.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/disokay/display/

lib/matplotlib/tri/trirefine.py Outdated
@@ -285,7 +285,7 @@ def _refine_triangulation_once(triangulation, ancestors=None):

# Now dealing with slave elems.
# for each slave element we identify the master and then the inode
# onces slave_masters is indentified, slave_masters_apex is such that:
# onces slave_masters is identified, slave_masters_apex is such that:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 19, 2018

Made changes. Please let me know when and I'll squash the commits.

Do you think it would be possible to run codespell on travis to make sure we do not put spelling errors in to begin with?

@tacaswell Yes, check out codespell-project/codespell#139 for some methodologies.

@jklymak
Copy link
Member

jklymak commented Jan 19, 2018

This has a couple of PEP8 lines that are too long, and needs a rebase...

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 19, 2018

@jklymak shall I use flake8 to check said issues? I checked flake8 and there is a lot of output. Not sure where to start.

@jklymak
Copy link
Member

jklymak commented Jan 19, 2018

Just drill down on the Travis-CI python 3.6 test. It lists the pep8 errors that we care about... You have a couple of lines that are too long...

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 22, 2018

@jklymak pep8 fixes submitted

@jklymak jklymak merged commit 6044a57 into matplotlib:master Jan 23, 2018
@luzpaz luzpaz deleted the more-misc-typos branch January 23, 2018 02:10
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luzpaz @tacaswell @jklymak @QuLogic