Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch the lasso selector to use mpl event handling, not input(). #10308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Switch the lasso selector to use mpl event handling, not input(). #10308

merged 1 commit into from
Jan 23, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 23, 2018

Interaction between input() and the GUI event loop can be generously
described as... complex.

Fixes the mwe at #10269; although more documentation (suggesting to not mix input and the event loop) would be nice. See also #10061.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Switch the lasso selector to use mpl event handling, not input().
8e7c133 
Interaction between input() and the GUI event loop can be generously
described as... complex.
@tacaswell tacaswell merged commit d7f69fe into matplotlib:master Jan 23, 2018
@tacaswell
Copy link
Member

I suspect this used to work because input is using readline from python (and IPython was using readline from python) so the OS_InputHook would be installed and active while input was waiting for the user to type.

With IPython moving away from readline (to prompt toolkit) the input hook is not being set anymore, hence the hanging.

@anntzer anntzer deleted the lasso-selector-no-input branch January 23, 2018 23:48
@QuLogic QuLogic added this to the v2.2 milestone Jan 24, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
@tacaswell tacaswell mentioned this pull request Jul 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic