Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix bug #3690: don't call evt.Skip() when window has just been destroyed #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2018
Merged

fix bug #3690: don't call evt.Skip() when window has just been destroyed #10415

merged 1 commit into from
Feb 11, 2018

Conversation

DietmarSchwertberger
Copy link
Contributor

PR Summary

Fixes #3690
Forwarding the event to a destroyed window caused the crash.

It would be best not to call evt.Skip() at all if a key was handled by FigureCanvasBase.key_press_event() but that's probably more difficult to implement.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@DietmarSchwertberger DietmarSchwertberger added this to the v2.2 milestone Feb 11, 2018
@tacaswell tacaswell merged commit 3b8c951 into matplotlib:master Feb 11, 2018
@tacaswell
Copy link
Member

Thanks @DietmarSchwertberger !

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DietmarSchwertberger @tacaswell @QuLogic