Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update some wx examples #10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2018
Merged

Update some wx examples #10416

merged 5 commits into from
Feb 12, 2018

Conversation

DietmarSchwertberger
Copy link
Contributor

PR Summary

embedding_in_wx4.py: remove unnecessary EVT_PAINT handler

fourier_demo_wx.py:

  • remove unnecessary EVT_PAINT and EVT_SIZE handlers
  • make things clearer: use a more standard wx structure (wx.Frame -> wx.Panel -> wx.BoxSizer-> FigureCanvasWxAgg) for easier understanding and correct background colours

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2 milestone Feb 11, 2018
@DietmarSchwertberger
Copy link
Contributor Author

Just noticed this at the start of the fourier example when using it for testing the Cairo PR code:

matplotlib.interactive(False)
matplotlib.use('WXAgg')
from matplotlib.backends.backend_wxagg import FigureCanvasWxAgg

I would think that the first two lines can be removed, right?

@tacaswell
Copy link
Member

If pyplot is not imported, those should be effectively no-ops.

@DietmarSchwertberger
Copy link
Contributor Author

I will remove them also from the other examples.

@tacaswell tacaswell merged commit 98a11ca into matplotlib:master Feb 12, 2018
@tacaswell
Copy link
Member

Thanks @DietmarSchwertberger !

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation GUI: wx
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DietmarSchwertberger @tacaswell @QuLogic @dstansby