Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove string escapes from matplotlibrc.template #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2018

Conversation

ImportanceOfBeingErnest
Copy link
Member

Remove string escapes from matplotlibrc.template.
This fixes #10406. Since the matplotlib rc file is not a python file, the rc arguments should not contain string escape characters. E.g. instead of formerly

boxplot.medianprops.color : 'C1'

it should read

boxplot.medianprops.color : C1

This change makes it easier to just uncomment the lines in the template file for use in a real rc file.

Note that I left some of the arguments in the "animations" section unchanged, because it is not clear what to put there instead. In any case, the fixed version of the template allows to uncomment any rc line (including those from the animations section) and not get a warning, so I suppose the animation parameters are correct, although they contain string escapes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

remove string escapes from matplotlibrc.template
@tacaswell tacaswell added this to the v2.2 milestone Feb 11, 2018
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jklymak
Copy link
Member

jklymak commented Feb 11, 2018

I don't see how this could break the docs or not pass any tests, but I won't merge in case my understanding is incorrect.

@tacaswell tacaswell merged commit d07de22 into matplotlib:master Feb 11, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib stylesheet warnings: Key boxplot.medianprops.color: 'C1' does not look like a color arg`
4 participants