Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup old print statements #10427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 12, 2018

PR Summary

Update comments and docstrings that use old print statements, either with functions or just removing the comments entirely.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2.0 milestone Feb 12, 2018
@tacaswell tacaswell merged commit 5bffbc3 into matplotlib:master Feb 12, 2018
@tacaswell
Copy link
Member

Lets see if I got the backport configuration set up right....

@tacaswell
Copy link
Member

@meeseeksdev backport to v2.2.x

@tacaswell
Copy link
Member

@Carreau any advice on what I have configured wrong for auto-backports to work?

@Carreau
Copy link
Contributor

Carreau commented Feb 12, 2018

Are you missing the on-merge: backport to v2.2.x in the milestone description ?

@tacaswell
Copy link
Member

"Release of v2.2.0 final release. on-merge: backport to v2.2.x" is the description.

@Carreau
Copy link
Contributor

Carreau commented Feb 12, 2018

"Release of v2.2.0 final release. on-merge: backport to v2.2.x" is the description.

Sorry, too early in the morning. Let me look at the logs.

@Carreau
Copy link
Contributor

Carreau commented Feb 12, 2018

Did you milestoned just before merging ? Because it seem the bot did not see the milestone when it saw the merged/pushed commits. Let me know if it still does not work on subsequent PRs.

@QuLogic QuLogic deleted the print-statements branch February 12, 2018 19:41
QuLogic pushed a commit that referenced this pull request Feb 13, 2018
QuLogic added a commit that referenced this pull request Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants