Set packet_ends = None before using in dviread.py #10454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__packed_ends__ is used on lines 649 and 653 but it is not defined/set until line 666. This drives linters nuts because it is safer to set variables before using them.
|
This currently works because the first if block is only triggered if one of the later blocks has set the state correct and also set the local variable? |
|
👍 modulo fixing the pep8 line-length issue. |
jkseppan
approved these changes
Feb 15, 2018
dstansby
added a commit
that referenced
this pull request
Feb 16, 2018
Backport PR #10454 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packed_ends is used on lines 649 and 653 but it is not defined/set until line 666. This drives linters nuts because it is safer to set variables before using them.
PR Summary
PR Checklist