FIX: DPI inconsistency of draggable legend #10469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Feb 15, 2018
dstansby
approved these changes
Feb 16, 2018
dstansby
added a commit
that referenced
this pull request
Feb 17, 2018
Backport PR #10469 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix for #10458 : draggable legend has an inconsistent offset behavior between the DPI value used for display and the DPI value used for saving. This was introduced in 199a87a due to some refactoring that was just a bit too eager. This PR simply reverts the one line that is causing the issue, and fixes some typos in a related docstring. Please see #10458 for more details about the issue (bisect, manual test script, etc.).
As the side remark, this issue was silently introduced because it affects an interactive part of Matplotlib, thus that it is not exercised by the test suite (if I a remember correctly).
PR Checklist