Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Separate plots using #### in xkcd.py #10478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2018
Merged

Separate plots using #### in xkcd.py #10478

merged 3 commits into from
Feb 17, 2018

Conversation

tropfcode
Copy link
Contributor

@tropfcode tropfcode commented Feb 15, 2018 •
edited
Loading

PR Summary

Separate plots using full line of # characters in matplotlib/examples/showcase/xkcd.py for Sphinx-gallery rendering per issue #8922

PR Checklist

  • Code is PEP 8 compliant
  • Has Pytest style unit tests
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tropfcode
Separate plots using #### in xkcd.py
659a417 
Separate plots using full line of '#' characters in xkcd.py for Sphinx-gallery rendering per issue matplotlib#8922
@tacaswell tacaswell added this to the v2.2-doc milestone Feb 15, 2018
jkseppan
jkseppan reviewed Feb 15, 2018
View reviewed changes
examples/showcase/xkcd.py Outdated
@@ -9,6 +9,8 @@
import numpy as np

with plt.xkcd():

###############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the unindented comment inside the with block is causing the error on CircleCI.

Copy link
Member

@QuLogic QuLogic Feb 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly; the ### splits up the file, so the with above is empty. This ### needs to go above the with context, and the one below would need a new with context as well.

@jkseppan
Copy link
Member

Now the Travis build is failing because of pep8 issues:

=================================== FAILURES ===================================
 PEP8-check(ignoring E111 E114 E115 E116 E121 E122 E123 E124 E125 E126 E127 E128 E129 E131 E226 E240 E241 E242 E243 E244 E245 E246 E247 E248 E249 E265 E266 E704 W503 E501 E402) 
[gw1] linux -- Python 3.6.3 /home/travis/virtualenv/python3.6.3/bin/python
/home/travis/build/matplotlib/matplotlib/lib/mpl_examples/showcase/xkcd.py:11:80: W291 trailing whitespace
###############################################################################
                                                                               ^
/home/travis/build/matplotlib/matplotlib/lib/mpl_examples/showcase/xkcd.py:13:17: W291 trailing whitespace
with plt.xkcd():
                ^

@QuLogic QuLogic merged commit e8a54b4 into matplotlib:master Feb 17, 2018
lumberbot-app bot pushed a commit that referenced this pull request Feb 17, 2018
@QuLogic
Backport PR #10478: Separate plots using #### in xkcd.py
f701967
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 17, 2018
Merged
WeatherGod added a commit that referenced this pull request Feb 17, 2018
@WeatherGod
Merge pull request #10512 from matplotlib/auto-backport-of-pr-10478
8a7a07d 
Backport PR #10478 on branch v2.2.x
@QuLogic QuLogic modified the milestones: v2.2-doc, v2.2.0 Feb 17, 2018
@tropfcode tropfcode deleted the patch-3 branch February 21, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@jkseppan jkseppan jkseppan approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tropfcode @jkseppan @QuLogic @tacaswell @dstansby