Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add libm when building Qhull. #10484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

Add libm when building Qhull. #10484

merged 1 commit into from
Feb 19, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 15, 2018

PR Summary

If you build with LDFLAGS=-Wl,--no-undefined and no system Qhull, you will get a bunch of errors due to missing math functions. This conditionally adds libm to the linker based on this post.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added the Build label Feb 15, 2018
@tacaswell tacaswell added this to the v2.2.0 milestone Feb 16, 2018
WeatherGod
WeatherGod approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'v run into similar oddities. Oftentimes, other libraries already have libm linked, so people forget to remember it for themselves.

@dopplershift dopplershift merged commit f304dca into matplotlib:master Feb 19, 2018
lumberbot-app bot pushed a commit that referenced this pull request Feb 19, 2018
@dopplershift
Backport PR #10484: Add libm when building Qhull.
8e0e44b
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 19, 2018
Merged
@QuLogic QuLogic deleted the qhull-libm branch February 19, 2018 21:06
dstansby added a commit that referenced this pull request Feb 20, 2018
@dstansby
Merge pull request #10536 from matplotlib/auto-backport-of-pr-10484
e7ab08e 
Backport PR #10484 on branch v2.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@WeatherGod WeatherGod WeatherGod approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @tacaswell @WeatherGod @dopplershift