BUG: sscanf did not parse arguments in _tkagg.cpp #10486
Conversation
|
Does anyone know why we need to route through |
|
Thanks for the quick fix @mattip ! |
|
@QuLogic My guess is that answer is lost to the sands of time and changing it is probably a bigger change than we want to fit in for 2.2. |
There was a problem hiding this comment.
Yeah, this is in the blitting code, which doesn't get a lot of attention. There has always been some weirdness with the image buffer and Tk because Tk does not provide a python API for passing it around.
Is this the only place where this is done? Have we looked at what is done elsewhere for the image buffer?
src/_tkagg.cpp
Outdated
| @@ -74,9 +74,9 @@ static int PyAggImagePhoto(ClientData clientdata, Tcl_Interp *interp, int | |||
| return TCL_ERROR; | |||
| } | |||
| /* get buffer from str which is "ptr height width" */ | |||
There was a problem hiding this comment.
you'll want to update the comment
|
@tacaswell sorry for not properly testing |
|
@ImportanceOfBeingErnest are you able to test this? |
|
@QuLogic If testing means building matplotlib from source, I'm affraid I can't do that currently. |
|
We can leave it for the next rc. |
|
@QuLogic : (Could you) Run the test suite, @ImportanceOfBeingErnest . (Sorry, I could not resist 🐑 . The exact reference is of course this one) |
Backport PR #10486 on branch v2.2.x
PR Summary
Fix issue #10479 which was caused by a quirk (bug?) in the way sscanf works on MSVC (windows). It seems that additional values cannot be used after "%Iu" which scans into size_t
Also added line drawing in an interactive test