Thanks to visit codestin.com
Credit goes to github.com

Skip to content

_macosx.m fails to compile on Mac OS 10.6.8 Snow Leopard - Issue #10516 #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2018
Merged

_macosx.m fails to compile on Mac OS 10.6.8 Snow Leopard - Issue #10516 #10519

merged 1 commit into from
Feb 18, 2018

Conversation

fvaccari
Copy link

@fvaccari fvaccari commented Feb 17, 2018 •
edited
Loading

PR Summary

I made just a small change to _macosx.m so that it can compile under Mac OS X 10.6.8 Snow Leopard. Without this, it fails with error

:info:build src/_macosx.m:1313: error: ‘for’ loop initial declaration used outside C99 mode
:info:build error: command '/usr/bin/llvm-gcc-4.2' failed with exit status 1

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@fvaccari fvaccari mentioned this pull request Feb 17, 2018
Closed
dopplershift
dopplershift approved these changes Feb 18, 2018
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough change to support the old version.

@tacaswell tacaswell added this to the v2.2.0 milestone Feb 18, 2018
@QuLogic QuLogic merged commit f2308fc into matplotlib:master Feb 18, 2018
@lumberbot-app lumberbot-app bot mentioned this pull request Feb 18, 2018
Merged
lumberbot-app bot pushed a commit that referenced this pull request Feb 18, 2018
@QuLogic
Backport PR #10519: _macosx.m fails to compile on Mac OS 10.6.8 Snow …
286d41b 
…Leopard - Issue #10516
QuLogic added a commit that referenced this pull request Feb 18, 2018
@QuLogic
Merge pull request #10521 from matplotlib/auto-backport-of-pr-10519
584420c 
Backport PR #10519 on branch v2.2.x
@fvaccari fvaccari deleted the _macosx.m_snow_leopard branch February 18, 2018 10:06
@tacaswell
Copy link
Member

Thanks @fvaccari ! 🎉 congratulations on what I think is your first Matplotlib contribution. Hopefully we will hear from you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fvaccari @tacaswell @dopplershift @QuLogic