Minor cleanup: PEP8, PEP257 #10542
Merged
Minor cleanup: PEP8, PEP257 #10542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Feb 20, 2018
| if axis in ["both", "x"]: | ||
| locs = [] | ||
| y1, y2 = self.axes.get_ylim() | ||
| #if self.axes.xaxis._gridOnMajor: | ||
| # if self.axes.xaxis._gridOnMajor: |
There was a problem hiding this comment.
seems quite clearly removable, below too
anntzer
reviewed
Feb 20, 2018
| self._axisline_on = True | ||
|
|
||
| helper = kw.pop("grid_helper", None) |
There was a problem hiding this comment.
target 3.0 and make this a kwonly argument?
anntzer
approved these changes
Feb 20, 2018
86bc45e to
590d69b
Compare
590d69b to
eb07c30
Compare
jklymak
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Minor code and docstring formatting changes to conform with PEP8 and PEP257.