Prevent ZeroDivisionError when devicePixelRatio() returns 0 #10568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I understand the underlying issue, but it does seem that a ratio of 0 makes no sense here, so returning 1 is better. |
jkseppan
approved these changes
Feb 24, 2018
timhoffm
reviewed
Feb 24, 2018
| @@ -269,7 +269,11 @@ def _update_figure_dpi(self): | |||
| def _dpi_ratio(self): | |||
| # Not available on Qt4 or some older Qt5. | |||
| try: | |||
| return self.devicePixelRatio() | |||
| ratio = self.devicePixelRatio() | |||
There was a problem hiding this comment.
simpler: return self.devicePixelRatio() or 1 # can be 0 in rare cases
There was a problem hiding this comment.
a comment would be nice, indeed.
* upstream/master: (42 commits) More style fixes. Remove more subprocess imports Add API note Bump a tolerance in test_axisartist_floating_axes. Minor style fixes. TST: colorbar check for constrained layout FIX: colorbar check for constrained layout Use 'yield from' where appropriate. Various style fixes. Remove some str() calls not needed on py3 Add subprocess deprecation message PEP8 fix for continuation of the line bugfix in axes3d Changed to "five" rcParams Might be `figure.constrained_layout.use` add a test use orientation value from kwargs Minor simplification to Figure.__getstate__ logic. Remove alternative for ispower2 Switch internal subprocess calls to python stdlib ...
timhoffm
reviewed
Feb 27, 2018
| return 1 | ||
| else: | ||
| return ratio | ||
| try: |
There was a problem hiding this comment.
I'm sorry, I should have double checked that...
timhoffm
approved these changes
Feb 27, 2018
|
@meeseeksdev backport to v2.2.x |
anntzer
added a commit
that referenced
this pull request
Feb 28, 2018
Backport PR #10568 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug only occurs under very special circumstances. For some reason when using Screen Scaling in KDE while also downscaling the terminal emulator Konsole, in which matplotlib is run, devicePixelRatio() returns 0 and causes a ZeroDevisionError. I do not know other circumstances under which this bug occurs. It is also probably not really a bug in matplotlib, but this fixes the issue for me.
You may ask why this setup is necessary to begin with, the answer can be found here. Essentially it is a workaround necessary to prevent screen tearing in Konsole for some very few people including myself.
PR Summary
PR Checklist