Move notify_axes_change to FigureManagerBase class. #10607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of duplicating it across backends. The additional cost on non-interactive backends is likely negligible.
dstansby
reviewed
Feb 26, 2018
| def notify_axes_change(fig): | ||
| 'this will be called whenever the current axes is changed' | ||
| if self.tb is not None: | ||
| self.tb.update() |
There was a problem hiding this comment.
Won't this cause problems here because the tool bar is self.tb and not self.toolbar like all the other backends?
There was a problem hiding this comment.
It is already aliased to toolbar too (in fact I'm getting rid of the tb alias in a separate PR).
tacaswell
previously requested changes
Feb 26, 2018
| self.toolbar = None | ||
|
|
||
| @self.canvas.figure.add_axobserver | ||
| def notify_axes_change(fig): |
There was a problem hiding this comment.
This also removes the method from all of the sub-classes.
There was a problem hiding this comment.
🐑 never mind, I thought this was a top-level method.
jklymak
approved these changes
Apr 4, 2018
timhoffm
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of duplicating it across backends. The additional cost on
non-interactive backends is likely negligible.
PR Summary
PR Checklist