Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecation fixes. #10672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2018
Merged

Deprecation fixes. #10672

merged 1 commit into from
Mar 4, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 4, 2018

  1. don't import matplotlib.compat.subprocess in __init__ (as that
    triggers a deprecation warning).
  2. using stacklevel=2 for warn_deprecated as default is not necessarily
    always sufficient, but will definitely be better than stacklevel=1 as
    default... (see https://docs.python.org/3/library/warnings.html#warnings.warn).
    xref Most warnings calls do not set the stacklevel #10643.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecation fixes.
5780fe7 
1) don't import matplotlib.compat.subprocess in `__init__` (as that
triggers a deprecation warning).
2) using stacklevel=2 for warn_deprecated as default is not necessarily
always sufficient, but will definitely be better than stacklevel=1 as
default... (see https://docs.python.org/3/library/warnings.html#warnings.warn).
@anntzer anntzer added this to the v3.0 milestone Mar 4, 2018
dstansby
dstansby approved these changes Mar 4, 2018
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when CI passes

@efiring efiring merged commit 3208322 into matplotlib:master Mar 4, 2018
@anntzer anntzer deleted the fixes branch March 4, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @dstansby @efiring