Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for shared axes diverging after setting tick markers #10691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Fix for shared axes diverging after setting tick markers #10691

wants to merge 10 commits into from

Conversation

shaynair
Copy link

@shaynair shaynair commented Mar 5, 2018

PR Summary

This fixes issue #8946.
A previous pull request #10651 was made, but I erroneously rebased to master which messed up the commit history there.

Example plot:
https://i.imgur.com/jipvFh3.png

Associated code snippet to reproduce the above plot:

import matplotlib.pyplot as plt
fig, (ax1, ax2) = plt.subplots(2, sharex=True)
ax1.plot(range(0, 10), range(0, 10))
ax2.plot(range(0, 10), range(0, 10))
plt.xticks(range(0, 30))
plt.show()

The two plots should be identical as they share the x-axis, but clearly aren't. This is a fix for this.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.0 milestone Mar 5, 2018
@shaynair
Copy link
Author

shaynair commented Mar 7, 2018 •
edited
Loading

Alright, I've incorporated the feedback given by @efiring. Please let me know what you think.

@shaynair shaynair mentioned this pull request Mar 9, 2018
Closed
6 tasks
jklymak
jklymak reviewed Mar 23, 2018
View reviewed changes
lib/matplotlib/axis.py Outdated
"""
If *ignore* is *False*, the order of vmin, vmax
does not matter; the original axis orientation will
be preserved. In addition, the view limits can be
expanded, but will not be reduced. This method is
expanded, but will not be reduced.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, while we are here, can we make these docstrings numpydoc compliant?

This file has almost no compliant docstrings (apparently it hasn't attracted the attention of @timhoffm, or he already has a PR in that hasn't been merged.)

As a random example of whats needed have a look at:

matplotlib/lib/matplotlib/figure.py

Line 1060 in b6acd04

def add_axes(self, *args, **kwargs):

If you don't feel like doing this, its probably fine, but it'd help..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make the entire file have compliant docstrings, or just the methods that I changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ha - go for the whole file if you want, but thats totally unfair. Just the strings you changed 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus, if you think thats too annoying, don't feel obliged. Someone will hit the whole file soon I'm sure...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did someone call me? 😉

@shaynair No seriously, only update the docstrings as part of this PR if you are touching them anyway. It simplifies the reviews if they are not too large and cover only one aspect. Also, keeping bugfixes and major docstring cleanups separate makes possible backports easier. That said, you are very welcome to open a separate PR for further docstring changes in the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I've updated it in my newest commit.

jklymak
jklymak approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it needs a whats-new entry because you've added API, though I admit the API is somewhat obscure. Not sure if you need an example that uses the new API. I guess there are times when we don't want the two axes to share ticks, in which case you'd set emit=False.

@jklymak jklymak requested a review from efiring July 16, 2018 16:13
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 23, 2018
@jklymak
Copy link
Member

jklymak commented Feb 11, 2019

This is still a bug in master, but will require some rebasing. Punting to 3.2, but @shaynair keep pushing this if you want it to go in!

@jklymak jklymak modified the milestones: v3.1.0, v3.2.0 Feb 11, 2019
@jklymak
Copy link
Member

jklymak commented Jul 24, 2019

@shaynair sorry this has taken a while to get approval. Unfortunately the way our approval system works, stuff needs to be re-pinged frequently to attract attention.

This needs a rebase, and then we can ask @efiring to look again.

@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 24, 2019
@timhoffm
Copy link
Member

Tried to rebase this, but I'm afraid this is beyond repair. Too much changed in the meantime, so that it would be easier to rewrite from scratch. The test could be recovered to document the problem and be a starting point for a fresh solution.

@shaynair I'm very sorry, this got lost and we couldn't bring it into matplotlib.

@timhoffm timhoffm closed this Aug 17, 2019
@timhoffm timhoffm mentioned this pull request Aug 17, 2019
Closed
@timhoffm
Copy link
Member

Test extracted, adapted and posted into the original issue: #8946 (comment)

@rayafarhadi rayafarhadi mentioned this pull request Feb 28, 2020
Closed
@rayafarhadi rayafarhadi mentioned this pull request Mar 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

@jklymak jklymak jklymak approved these changes

@efiring efiring Awaiting requested review from efiring

Assignees
No one assigned
Labels
API: consistency Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: needs rebase
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shaynair @jklymak @timhoffm @tacaswell