-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: re-instate verbose alias #10726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: re-instate verbose alias #10726
Conversation
You almost certainly need to 1) wrap that in something that catches the deprecation warning, and 2) add a deprecation warning to all methods of verbose (as the user will not see the one in the ctor (unless he decides to build his own instance of Verbose)). |
I get the deprecation warning with from matplotlib import verbose Not good enough? |
you probably get it with just "import matplotlib" no?... |
Oh goodness I hope not. If so hints on wrapping appreciated. |
Just wrap all methods manually too. |
I didn't realize it when we had the RC's, but I think this broke PyCharm's support for embedding figures. Not to make this any worse or anything. 😉 |
OK, well, this is a bit out of my depth. import matplotlib indeed triggers the deprecation warning if I have in # define verbose so it can be imported...
verbose = Verbose() I don't know how to turn that warning off and still assign |
8c63473
to
a10e0ee
Compare
OK< think I got it. import matplotlib
from matplotlib import verbose issues no warnings. But verbose.report('Boo') does.... |
a10e0ee
to
b603978
Compare
Looks like this can go in after a rebase. |
b603978
to
eecdc3c
Compare
@dopplershift this is a good example of a mysterious failing codecov/project/tests. |
Because macOS builds didn't upload any coverage... |
Ahhhh. Cool. Thanks! |
Backport PR #10726 on branch v2.2.x
I think something went wrong with the rebase as this does not actually but |
PR Summary
The
verbose
alias was inadvertently dropped so folks can no longerGiven that this is public API, it should not have been removed...
closes #10716
PR Checklist