Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: reorder linewidth setting before linestyle #10742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 9, 2018

PR Summary

This closes #10719

line.set_linewidth was being called after line.set_linestyle but set_linestyle needs self._linewidth. In #10719, the user was passing a string, which maybe they shouldn't, but if set_linewidth is called first, it will cast the string....

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0 milestone Mar 9, 2018
@timhoffm timhoffm merged commit 2ad362a into matplotlib:master Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better type error checking for linewidth in ax.grid
3 participants