Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix undefined name. Add animation tests. #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2018
Merged

Fix undefined name. Add animation tests. #10801

merged 2 commits into from
Mar 21, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 15, 2018

PR Summary

xref #10793 (comment)
Sorry :)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 15, 2018
@anntzer anntzer added this to the v3.0 milestone Mar 15, 2018
afvincent
afvincent approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@afvincent afvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If this undefined variable never was an issue, does that mean that this code path is never exercised during the tests (genuine question)?

@tacaswell
Copy link
Member

Yeah, we do not force it to try to save a too-big animation to js.

@dopplershift
Copy link
Contributor

Oops. 🐑

@jklymak
Copy link
Member

jklymak commented Mar 15, 2018

... I told @anntzer that I trusted him... and the tests.

@dopplershift
Copy link
Contributor

Yeah, I see now that I didn't screw it up originally. 😁

@anntzer
Copy link
Contributor Author

anntzer commented Mar 15, 2018 •
edited
Loading

Well, I'm writing tests for the whole thing right now and it looks like (tbc?) I'm finding an unrelated bug in html5 output... so perhaps that was a good thing that I'm breaking stuff here and there :p
edit: oh, it's just an instance of #9205.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 15, 2018 •
edited
Loading

Added some tests, including an xfailing one :-)
btw I think we should replace most instances of xfail in the test suite by skipifs, so that xfail really means "this is a bug that we need to fix", not "the preconditions for running the test (e.g. OS, 3rd-party module) are not satisfied".

@anntzer anntzer force-pushed the fix-undefined-name branch from 0a22a47 to f5392d6 Compare March 16, 2018 00:02
@anntzer anntzer changed the title Fix undefined name. Fix undefined name. Add animation tests. Mar 16, 2018
@anntzer anntzer force-pushed the fix-undefined-name branch from f5392d6 to 4192b15 Compare March 16, 2018 00:31
@tacaswell
Copy link
Member

Issue is we don't have ffmpeg installed on appveyor.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 16, 2018

yup, working on that
stupid avconv :/

@anntzer anntzer force-pushed the fix-undefined-name branch from 4192b15 to ef8df26 Compare March 16, 2018 02:17
@anntzer
Copy link
Contributor Author

anntzer commented Mar 16, 2018

Added ppa to travis to install ffmpeg (not available by default on trusty) instead of avconv, given that that's actually our default converter...

@anntzer anntzer force-pushed the fix-undefined-name branch from ef8df26 to a65fb4a Compare March 16, 2018 02:23
@anntzer anntzer force-pushed the fix-undefined-name branch 3 times, most recently from 119eef9 to 7178b98 Compare March 16, 2018 17:04
jkseppan
jkseppan reviewed Mar 16, 2018
View reviewed changes
doc/devel/testing.rst
@@ -25,7 +25,7 @@ local FreeType build

The following software is required to run the tests:

- pytest_ (>=3.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 3.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, fixed

@anntzer anntzer force-pushed the fix-undefined-name branch from 7178b98 to d380247 Compare March 16, 2018 21:23
@jklymak
Copy link
Member

jklymak commented Mar 21, 2018

Four approvals, but needs a rebase!

@anntzer anntzer force-pushed the fix-undefined-name branch from d380247 to b114131 Compare March 21, 2018 15:57
@anntzer
Copy link
Contributor Author

anntzer commented Mar 21, 2018

Trying to beat the record of the most approvals on a PR :p rebased.

jklymak
jklymak approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to help you break the record; not that I really follow all the code. Thanks a lot for the extra test!

@jklymak jklymak merged commit 186b3b3 into matplotlib:master Mar 21, 2018
@anntzer anntzer deleted the fix-undefined-name branch March 21, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan approved these changes

@tacaswell tacaswell tacaswell approved these changes

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak jklymak approved these changes

@afvincent afvincent afvincent approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@anntzer @tacaswell @dopplershift @jklymak @jkseppan @afvincent @QuLogic