Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: restore verbose attribute at top level #10816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2018
Merged

FIX: restore verbose attribute at top level #10816

merged 1 commit into from
Mar 17, 2018

Conversation

tacaswell
Copy link
Member

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

dopplershift
dopplershift approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.

@tacaswell tacaswell added this to the v2.2.1 milestone Mar 16, 2018
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 16, 2018
@jklymak
Copy link
Member

jklymak commented Mar 17, 2018

How the heck did that happen. Sorry about that....

@tacaswell
Copy link
Member Author

@jklymak I hit the merge button so I should take most of the blame for this one.

Caught it before we pushed anything to pypi so we can just tag 2.2.2 as soon as this is merged and carry on from there!

@jklymak
Copy link
Member

jklymak commented Mar 17, 2018

I’m actually curious what happened because I had those changes in (except for the test appaerntly).

@phobson phobson merged commit e75bbc0 into matplotlib:v2.2.x Mar 17, 2018
@tacaswell tacaswell deleted the fix_verbose branch March 17, 2018 02:15
@tacaswell
Copy link
Member Author

@jklymak Looking at git reflog may help reconstruct what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @jklymak @dopplershift @phobson