Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't use private attribute in tk example. Fix Toolbar class rename. #10838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2018
Merged

Don't use private attribute in tk example. Fix Toolbar class rename. #10838

merged 1 commit into from
Mar 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 19, 2018

PR Summary

Closes #3871.
release critical as the old name for the Toolbar class doesn't exist anymore, so the example fails.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Mar 19, 2018
@anntzer anntzer added this to the v3.0 milestone Mar 19, 2018
@tacaswell tacaswell merged commit 8991f9f into matplotlib:master Mar 19, 2018
@anntzer anntzer deleted the publictk branch March 19, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

replace use of _tkcanvas with get_tk_widget()
2 participants
@anntzer @tacaswell