Unsixification #10846
Merged
Unsixification #10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93ad100 to
7be23ff
Compare
timhoffm
approved these changes
Mar 20, 2018
|
Should we concerned by the drop in tests codecov? I've heard thats bad news... |
|
That's because we're removing a bunch of "import six" which were covered... |
tacaswell
approved these changes
Mar 21, 2018
|
If you clean up test_basic.py you will be able to push your test coverage back up by removing some un-tested py2 only paths. |
|
tests will have their own PR... some day if no one else beats me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Die, Py2, die... :p
(Tried to keep this to the "trivial" cases.)
PR Checklist