Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inline knownfailureif. #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

Inline knownfailureif. #10905

merged 1 commit into from
Mar 28, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 28, 2018

Now that nose support has been dropped, knownfailureif is just a thin
wrapper around pytest.mark.xfail that's more obfuscating the purpose of
the code than anything else.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline knownfailureif.
49e2b0e 
Now that nose support has been dropped, knownfailureif is just a thin
wrapper around pytest.mark.xfail that's more obfuscating the purpose of
the code than anything else.
@anntzer anntzer added this to the v3.0 milestone Mar 28, 2018
@tacaswell tacaswell merged commit 8effa93 into matplotlib:master Mar 28, 2018
@anntzer anntzer deleted the knownfailureif branch March 28, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @tacaswell