Make draggable callbacks check that artist has not been removed. #10908
Conversation
lib/matplotlib/offsetbox.py
Outdated
| self.finalize_offset() | ||
| self.got_artist = False | ||
| self.canvas.mpl_disconnect(self._c1) | ||
|
|
||
| if self._use_blit: | ||
| self.ref_artist.set_animated(False) | ||
|
|
||
| def _check_still_parented(self): | ||
| if self.ref_artist.axes is None: |
There was a problem hiding this comment.
should probably check self.ref_artist.figure too incase there are draggable things at the figure level.
|
👍 I like this solution much better. |
53f4fb5 to
d5a39f4
Compare
|
Thoughts about moving away from using weakmethods in callbackregistry (see other thread for arguments)? (note that that has a reasonable deprecation pathway: when we were going to remove a weakmethod from the registry, instead insert a proxy method that emits a warning the next time it's called) |
|
Want to give more thought to changing away from weakrefs before taking a position, but my bias is to not change. |
@tacaswell FWIW, I just noticed that widgets.py uses its own callback-handling mechanism and just uses strong refs without doing anything special; no one seems to be bothered by that... |
PR Summary
Simpler solution to #10876 (see in particular #10876 (comment)).
PR Checklist