Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve docstring of Axes.matshow #10991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Apr 8, 2018

PR Summary

As part of #10148: Docstring update for Axes.matshow.

Plot a matrix or array as an image.
Plot the values of a 2D matrix or array as color-coded image.

This is just a convenience function wrapping `.imshow` to set useful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth putting this (rather technical list) below in a notes section, since the average user probably just wants to see a matrix and not bother about imshow options.

imshow : plot an image
imshow : More general function to plot data on a 2D regular raster.

Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want this as Notes instead of Note? Formats differently....

Copy link
Member Author

@timhoffm timhoffm Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I don't think this should go in a callout box ( .. note::). It's rather just an explanation, not something to watch out for.

Note: In numpydoc, there's just the short and long description and the sections (Parameters etc.) There's no way to add arbitrary content below the parameters. I.e. if we want to move this out of the way, it has to be the Notes section, which is fine.

@jklymak jklymak merged commit 3046e25 into matplotlib:master Apr 8, 2018
@timhoffm timhoffm deleted the doc-axes-matshow branch April 8, 2018 17:58
@jklymak jklymak added this to the v2.2-doc milestone Apr 8, 2018
@jklymak
Copy link
Member

jklymak commented Apr 8, 2018

@meseeksdev v2.2-doc

@jklymak
Copy link
Member

jklymak commented Apr 8, 2018

@meeseeksdev v2.2-doc

@jklymak
Copy link
Member

jklymak commented Apr 8, 2018

@meeseeksdev backport to v2.2-doc

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 8, 2018

Something went wrong ... Please have a look at my logs.

@jklymak
Copy link
Member

jklymak commented Apr 8, 2018

@meeseeksdev backport to v2.2.2-doc

jklymak added a commit that referenced this pull request Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants