Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use chained comparisons where reasonable. #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

Use chained comparisons where reasonable. #11066

merged 1 commit into from
Apr 17, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 17, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone Apr 17, 2018
timhoffm
timhoffm reviewed Apr 17, 2018
View reviewed changes
lib/matplotlib/_constrained_layout.py Outdated
return True
return False
return (colnumCmin <= colnum0min <= colnumCmax
and colnumCmin <= colnum0max <= colnumCmax)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this does but the original logic is ˋorˋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh... fixed

lib/matplotlib/_constrained_layout.py Outdated
return True
return False
return (rownumCmin <= rownum0min <= rownumCmax
and rownumCmin <= rownum0max <= rownumCmax)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or

@anntzer anntzer force-pushed the chainedcomparisons branch from be9b6e3 to cbd6491 Compare April 17, 2018 08:24
@tacaswell tacaswell merged commit 304154c into matplotlib:master Apr 17, 2018
@anntzer anntzer deleted the chainedcomparisons branch April 17, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell