Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move remaining examples from api/ #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2018
Merged

Move remaining examples from api/ #11136

merged 3 commits into from
Jun 29, 2018

Conversation

dstansby
Copy link
Member

No description provided.

@jklymak
Copy link
Member

jklymak commented May 1, 2018

https://circleci.com/gh/dstansby/matplotlib/796/artifacts/0//home/circleci/project/doc/build/html/index.html

jklymak
jklymak approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstansby, this is great! Umm, I'm approving, but I've not gone through and checked that all links were set. I assume you did a search for /api/ or somesuch?

QuLogic
QuLogic requested changes May 1, 2018
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still links to api in this branch, at the very least to legend.py, e.g., https://796-74355158-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/devel/documenting_mpl.html#adding-figures

@dstansby
Copy link
Member Author

dstansby commented May 7, 2018

I've searched for gallery/api and examples/api and think I've got all the links now.

QuLogic
QuLogic approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some text in examples/README should be updated?

@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Jun 1, 2018
Merged
@dstansby
Copy link
Member Author

I think this is finally ready to be reviewed!

@dstansby dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 27, 2018
@dstansby dstansby added this to the v3.0 milestone Jun 27, 2018
@tacaswell tacaswell merged commit 5c32712 into matplotlib:master Jun 29, 2018
@dstansby dstansby deleted the examplemove branch June 29, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @jklymak @QuLogic @tacaswell