Remove mpl_examples symlink. #11141
Remove mpl_examples symlink. #11141
Conversation
AFAICT we're not using it for anything, we don't have a similar symlink to the tutorials, and it annoys my tab-completion when I try to get into mpl_toolkits...
|
does this affect what goes into the build products when we release? |
|
The docs look fine. Is it there to maintain links? Or maybe archived links instead of returning a 404? |
|
The sdist actually contains 2 copies of the examples, as the tgz (or probably the distutils archiver) doesn't keep mpl_examples as a symlink. |
|
This will need a deprecation note then is case down-stream consumers are expecting this directory. |
|
Not sure how you want to word this, can you directly push to the PR? |
|
nvm, I can't read, that symlink was in doc, not in lib. |
|
@sandrotosi @QuLogic Can you verify this won't mess up debian and fedora packaging? |
|
We don't install it, and currently don't even build the docs, so I'm not sure it's really needed here. |
|
thanks @tacaswell for checking with the distro packagers! yes this should be fine for debian (you plan on keep distributing the |
|
@sandrotosi Yes |
Due to the removal of the symlink in matplotlib#11141, pytest was no longer picking up the examples and running pep8 on them.
Due to the removal of the symlink in matplotlib#11141, pytest was no longer picking up the examples and running pep8 on them.
AFAICT we're not using it for anything, we don't have a similar symlink
to the tutorials, and it annoys my tab-completion when I try to get into
mpl_toolkits...
PR Summary
PR Checklist