Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use GLib.MainLoop() instead of deprecated GObject.MainLoop() #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

Use GLib.MainLoop() instead of deprecated GObject.MainLoop() #11182

merged 1 commit into from
May 7, 2018

Conversation

expectocode
Copy link
Contributor

PR Summary

Using GObject.MainLoop emits this warning:

[omitted]/lib/python3.6/site-packages/matplotlib/pyplot.py:101: PyGIDeprecationWarning: GObject.MainLoop is deprecated; use GLib.MainLoop instead
  ml = GObject.MainLoop

My PR follows the suggestion of the warning, and changes GObject.MainLoop for GLib.MainLoop.

@tacaswell tacaswell added this to the v3.0 milestone May 7, 2018
@tacaswell
Copy link
Member

How far back in gi history is GLib available like this?

If we currently support versions of gi that do not have GLib we either need to shim this import based on version or bump our minimum version.

@expectocode
Copy link
Contributor Author

This page suggests 2.15.2 - 2008-07-26 is the first version with this in.

@anntzer anntzer merged commit cffca75 into matplotlib:master May 7, 2018
@anntzer
Copy link
Contributor

anntzer commented May 7, 2018

thanks!

@ederag ederag mentioned this pull request Apr 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@expectocode @tacaswell @anntzer @QuLogic