Minor cleanups to pyplot. #11205
Merged
Minor cleanups to pyplot. #11205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 9, 2018
lib/matplotlib/pyplot.py
Outdated
| @@ -121,8 +122,7 @@ def install_repl_displayhook(): | |||
| Install a repl display hook so that any stale figure are automatically | |||
| redrawn when control is returned to the repl. | |||
|
|
|||
| This works with IPython terminals and kernels, | |||
| as well as vanilla python shells. | |||
| This works with both with IPython and with vanilla python shells. | |||
There was a problem hiding this comment.
Not a language expert, but this feels doubled. Either "This works with IPython and with vanilla python shells." or "This works with both IPython and vanilla python shells."
lib/matplotlib/pyplot.py
Outdated
| lines.append(sep) | ||
|
|
||
| lines = [ | ||
| sep, |
There was a problem hiding this comment.
A bit niggling, but I like readable names. 😄. Can we make it separator or even table_separator?
The use of inspect.cleandoc instead of str.strip() in _setup_pyplot_info_docstrings correctly dedents the docstring in the case the first "sentence" spreads over 2+ lines (e.g. for install_repl_displayhook).
|
both fixed |
jklymak
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of inspect.cleandoc instead of str.strip() in
_setup_pyplot_info_docstrings correctly dedents the docstring in the
case the first "sentence" spreads over 2+ lines (e.g. for
install_repl_displayhook).
PR Summary
PR Checklist