Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update venv gui docs wrt availability of PySide2. #11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 9, 2018

PR Summary

(milestoning as 3.0 as that version of the venv docs only documents stuff for Py3, e.g. assuming that the venv module is builtin).

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone May 9, 2018
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from a doc point of view. I'll leave open for a day or two if someone wants to argue about the accuracy of this....

Qt5 PyQt5 yes yes
Qt5 PySide2 yes [#]_ yes
Qt4 PyQt4 no yes
Qt4 PySide Windows yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Windows and OSX?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason there are no OSX wheels at https://pypi.org/project/PySide/#files, but they are there for the previous release (1.2.2) (https://pypi.org/project/PySide/1.2.2/#files), which I guess is good enough. Restored the mention of OSX.

@timhoffm timhoffm merged commit 9be2a7c into matplotlib:master May 14, 2018
@anntzer anntzer deleted the venvguidocs branch May 15, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants