Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate the examples.directory rcParam. #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

Deprecate the examples.directory rcParam. #11240

merged 1 commit into from
Jul 5, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 13, 2018

It is always found in the sample_data subdirectory relative to what the
datapath rcParam indicates now. The latter should already provide
enough flexibility for downstream packagers that want to tear the
package apart...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone May 13, 2018
@anntzer anntzer force-pushed the deprecate-examples-directory branch 3 times, most recently from f9ed276 to 76346c7 Compare May 15, 2018 06:56
@jklymak jklymak added the Build label May 17, 2018
efiring
efiring approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to rebase and tests passing.

@anntzer
Deprecate the examples.directory rcParam.
63f53e3 
It is always found in the sample_data subdirectory relative to what the
``datapath`` rcParam indicates now.  The latter should already provide
enough flexibility for downstream packagers that want to tear the
package apart...
@anntzer anntzer force-pushed the deprecate-examples-directory branch from 76346c7 to 63f53e3 Compare July 4, 2018 12:01
@anntzer
Copy link
Contributor Author

anntzer commented Jul 4, 2018

rebased

@efiring
Copy link
Member

efiring commented Jul 4, 2018

Failing on test_interactive_backend[wxagg] for python 3.7. That's unrelated to this PR, but does it mean more fiddling with the Travis configuration will be needed?

@anntzer
Copy link
Contributor Author

anntzer commented Jul 4, 2018

probably...

@jklymak jklymak merged commit aae55fc into matplotlib:master Jul 5, 2018
@anntzer anntzer deleted the deprecate-examples-directory branch July 5, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @efiring @QuLogic @jklymak