Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove mplDeprecation #11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

Remove mplDeprecation #11247

merged 1 commit into from
Jul 9, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented May 15, 2018 •
edited
Loading

This is just an alias to MatplotlibDeprecationWarning. Explicitly using the latter is preferred.

Is cbook considered public API? If so, we have do add a deprecation cycle for mplDeprecation.

PR Checklist

  • Code is PEP 8 compliant
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0 milestone May 15, 2018
@tacaswell
Copy link
Member

cbook is public API. We are going to deprecate the deprecation? 😈

@anntzer
Copy link
Contributor

anntzer commented May 15, 2018

#10735 may be useful here...

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch 3 times, most recently from 0a35d2a to 9ea3bab Compare May 16, 2018 06:01
@timhoffm
Copy link
Member Author

@anntzer Thanks for the hint on #10735. It's an interesting approach. However I think it's a bit overkill for the present case.

Likely, very few people will use mplDeprecation. It's not part of the docs (except for a mention in a list of changes). Users who want to filter out warnings will have used MatplotlibDeprecationWarning since this is what they will have seen as the warning type.

I've added a deprecation note and think that's enough.

jklymak
jklymak approved these changes May 25, 2018
View reviewed changes
doc/api/next_api_changes/2018-05-16-TH.rst Outdated
`````````````````````````````````````````````````````````````

:class:`matplotlib.cbook.deprecation.mplDeprecation` will be removed in
future versions. It is just an for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume "It is just an alias for"...

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch from 9ea3bab to 351636c Compare May 26, 2018 14:45
@anntzer
Copy link
Contributor

anntzer commented May 26, 2018

Likely, very few people will use mplDeprecation.

You mean, like #10716? :) I would also like to see it go away, but I'll leave it to @tacaswell to make the final call.

@timhoffm
Copy link
Member Author

cbook.mplDeprecation still exists. Do we also still need matplotlib.mplDeprecation and matplotlib.pyplot.mplDeprecation?

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch 2 times, most recently from f5dbacd to 1c5c86d Compare June 3, 2018 19:43
@timhoffm
Copy link
Member Author

timhoffm commented Jun 3, 2018

To be on the safe side, I've kept matplotlib.mplDeprecation and matplotlib.pyplot.mplDeprecation for now. Will be removed after the deprecation period.

jkseppan
jkseppan reviewed Jun 4, 2018
View reviewed changes
lib/matplotlib/__init__.py Outdated
@@ -140,7 +140,8 @@
# definitions, so it is safe to import from it here.
from . import cbook
from matplotlib.cbook import (
mplDeprecation, dedent, get_label, sanitize_sequence)
MatplotlibDeprecationWarning, dedent, get_label, sanitize_sequence)
fom matplotlib.cbook import mplDeprecation # deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be right? Should read from instead of fom.

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch 2 times, most recently from d8a7c80 to 4fd04f9 Compare June 4, 2018 18:26
@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch from 4fd04f9 to c0c33cd Compare July 1, 2018 20:53
@anntzer
Copy link
Contributor

anntzer commented Jul 1, 2018

Not to be a pain :-) but I would appreciate if #11297 (which completely gets rid of quite a few of these mplDeprecations, rather than just renaming them; and which is already approved twice) could go in first...

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch from c0c33cd to eb0bbfa Compare July 1, 2018 22:57
anntzer
anntzer reviewed Jul 1, 2018
View reviewed changes
lib/matplotlib/pyplot.py Outdated
@@ -33,6 +33,7 @@
from matplotlib import _pylab_helpers, interactive
from matplotlib.cbook import (
dedent, deprecated, silent_list, warn_deprecated, _string_to_bool)
from matplotlib.cbook import mplDeprecation # deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't needed?

@timhoffm timhoffm force-pushed the cleanup-mplDeprecation branch from eb0bbfa to a1419cc Compare July 2, 2018 00:02
@tacaswell tacaswell merged commit 1209037 into matplotlib:master Jul 9, 2018
@tacaswell
Copy link
Member

Thanks @timhoffm !

@timhoffm timhoffm deleted the cleanup-mplDeprecation branch July 9, 2018 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan left review comments

@anntzer anntzer anntzer left review comments

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@timhoffm @tacaswell @anntzer @jkseppan @jklymak @QuLogic @dstansby